Localize placeholder based on first language #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/index.js
Outdated
| * Otherwise, if language is provided in options, then use the localized string of the first language if available | ||
| * Otherwise use the default | ||
| */ | ||
| getPlaceholderText: function(){ |
There was a problem hiding this comment.
should this method be private?
There was a problem hiding this comment.
related to https://github.com/mapbox/mapbox-gl-geocoder/pull/198/files#r265396617 but I think it's better to re-gen the docs with each commit and include them.
There was a problem hiding this comment.
Good catch. Moved this to be a private method.
| var localizedValue = localization.placeholder[language]; | ||
| if (localizedValue) return localizedValue; | ||
| } | ||
| return 'Search'; |
There was a problem hiding this comment.
you could also lookup 'en' in localization.placeholder, but I don't think it really matters.
| * | ||
| * If placeholder is provided in options, then use options.placeholder | ||
| * Otherwise, if language is provided in options, then use the localized string of the first language if available | ||
| * Otherwise use the default |
There was a problem hiding this comment.
I think we should add a JSDoc @returns here for completeness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the change suggested in #150 by localizing the placeholder value based on the provided language option set in the constructor.